New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Improved Cisco Unified CM detection and renamed to ucos #6813

Merged
merged 1 commit into from Jun 19, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Jun 9, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This relies on librenms/librenms.github.io#90

ucos seems the better os name: http://www.cisco.com/c/en/us/td/docs/voice_ip_comm/cucm/cucos/7_1_2/cucos/osg_712_cm/iptpch2.html

Why not cucos, well we don't have cnxos or cios yet these are called Cisco NX-OS and Cisco IOS....

@laf laf added the Device 🖥 label Jun 9, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 9, 2017

Auto-Deploy finished, Test PR at http://6813.ci.librenms.org or https://6813.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 9, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jun 9, 2017

The inspection completed: No new issues

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jun 13, 2017

Member

@laf this looks good if you want to re-date the notification and send that out.

Member

murrant commented Jun 13, 2017

@laf this looks good if you want to re-date the notification and send that out.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jun 13, 2017

Member

Done.

Member

laf commented Jun 13, 2017

Done.

@murrant murrant merged commit 2e43adc into librenms:master Jun 19, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:newdevice/issue-6760 branch Jun 19, 2017

dnapper added a commit to dnapper/librenms that referenced this pull request Jun 19, 2017

@Rosiak Rosiak referenced this pull request Jun 26, 2017

Closed

New Device: Cisco Unified CM System version: 7.1.5.35901-1 #6760

5 of 5 tasks complete
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.