Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add quanta lb6m #6816
Adding Quanta LB6M stats.
cpu usage, mempool, fan speed, psu status, and temperature
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
Looks great overall. I've put some comments in but the general is:
Try not to use snmp_walk() and use snmpwalk_cache_* instead. It gives you better formatted data.
Use named OIDs instead of numerical in all the snmp calls if you can, it makes reading the code and what data to expect easier.
For the mibs, you've got a lot of what's already available in the main mibs folder, like bgp.my (BGP4-MIB). You will need to remove all of those.
Thanks for submitting the PR :)
Few more things I've commented on.
Also the mibs, you've still got some that are already available, the ones I said last time were just example. So you'll need to remove those duplicates.
The build failure looks unrelated.