New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at implementing ExtremeWireless support #6819

Merged
merged 6 commits into from Jul 3, 2017

Conversation

Projects
None yet
5 participants
@trs80
Contributor

trs80 commented Jun 11, 2017

Includes global AP and user count, and per-AP user count

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

I haven't run ./scripts/pre-commit.php as I don't have composer set up, I mostly want to see what people and the CI bots think of this.

First pass at implementing ExtremeWireless support
Includes global AP and user count, and per-AP user count

@trs80 trs80 referenced this pull request Jun 11, 2017

Closed

Wireless support for ExtremeWireless controller #6791

5 of 5 tasks complete
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 11, 2017

Auto-Deploy finished, Test PR at http://6819.ci.librenms.org or https://6819.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 11, 2017

Auto-Deploy finished, Test PR at http://6819.ci.librenms.org or https://6819.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 11, 2017

Auto-Deploy finished, Test PR at http://6819.ci.librenms.org or https://6819.ci.librenms.org

@laf

Looks good to me. If you can rename the mibs to drop the .my extensions that would be good.

Show outdated Hide outdated LibreNMS/OS/Ewc.php Outdated
Show outdated Hide outdated LibreNMS/OS/Ewc.php Outdated
Show outdated Hide outdated LibreNMS/OS/Ewc.php Outdated
Show outdated Hide outdated LibreNMS/OS/Ewc.php Outdated
Show outdated Hide outdated LibreNMS/OS/Ewc.php Outdated
Show outdated Hide outdated LibreNMS/OS/Ewc.php Outdated
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 18, 2017

Auto-Deploy finished, Test PR at http://6819.ci.librenms.org or https://6819.ci.librenms.org

Show outdated Hide outdated LibreNMS/OS/Ewc.php Outdated
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 19, 2017

Auto-Deploy finished, Test PR at http://6819.ci.librenms.org or https://6819.ci.librenms.org

1 similar comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 19, 2017

Auto-Deploy finished, Test PR at http://6819.ci.librenms.org or https://6819.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 19, 2017

Auto-Deploy finished, Test PR at http://6819.ci.librenms.org or https://6819.ci.librenms.org

@trs80

This comment has been minimized.

Show comment
Hide comment
@trs80

trs80 Jun 19, 2017

Contributor

OK, I'm happy with this to be committed, I'll work on the other sensors (frequency, SNR etc.) over time.

Contributor

trs80 commented Jun 19, 2017

OK, I'm happy with this to be committed, I'll work on the other sensors (frequency, SNR etc.) over time.

Show outdated Hide outdated LibreNMS/OS/Ewc.php Outdated
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 3, 2017

Auto-Deploy finished, Test PR at http://6819.ci.librenms.org or https://6819.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 3, 2017

The inspection completed: 3 updated code elements

scrutinizer-notifier commented Jul 3, 2017

The inspection completed: 3 updated code elements

@trs80

This comment has been minimized.

Show comment
Hide comment
@trs80

trs80 Jul 3, 2017

Contributor

Any further thoughts?

Contributor

trs80 commented Jul 3, 2017

Any further thoughts?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 3, 2017

Member

We were just waiting on you before that last commit.

Member

laf commented Jul 3, 2017

We were just waiting on you before that last commit.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 3, 2017

Member

Looks good to me.

Member

murrant commented Jul 3, 2017

Looks good to me.

@murrant murrant merged commit 5020f47 into librenms:master Jul 3, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.