New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add support to use IP addresses for NfSen filenames #6824

Merged
merged 2 commits into from Jun 13, 2017

Conversation

Projects
None yet
4 participants
@aldemira
Contributor

aldemira commented Jun 13, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Many environments that I've worked on doesn't add a DNS name to it's network devices. So I usually have IP addresses in monitoring systems. However, NfSen integration assumes using an fqdn. So I'm thinking if we do not set $config['nfsen_split_char'] it assumes we're using an IP or a hostname (not a fqdn)

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 13, 2017

The inspection completed: 1 new issues

The inspection completed: 1 new issues

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

@laf laf merged commit 0ede952 into librenms:master Jun 13, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@aldemira aldemira deleted the aldemira:nfsen branch Jul 5, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.