New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for syslog-messages from zywall (USG series) #6838

Merged
merged 2 commits into from Jun 20, 2017

Conversation

Projects
None yet
4 participants
@Olen
Contributor

Olen commented Jun 14, 2017

I am not sure this works for ALL ZyWalls, but it seems like host os is used before, so I just assumed Zyxel have some kind of consistency in their bugs...
This patch makes nicely formatted Syslog entries from my USG60 at least.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jun 15, 2017

Member

Can you create a test (or tests) for this in tests/SyslogTest.php ?

Member

murrant commented Jun 15, 2017

Can you create a test (or tests) for this in tests/SyslogTest.php ?

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 15, 2017

The inspection completed: 1 updated code elements

The inspection completed: 1 updated code elements

@murrant murrant merged commit b845286 into librenms:master Jun 20, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.