New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: discovery code cleanups #6856

Merged
merged 4 commits into from Jun 22, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Jun 16, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

murrant added some commits Jun 16, 2017

use get_port_by_ifIndex
get rid of the rest of the array_keys()
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Jun 16, 2017

Auto-Deploy finished, Test PR at http://6856.ci.librenms.org or https://6856.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Jun 16, 2017

Auto-Deploy finished, Test PR at http://6856.ci.librenms.org or https://6856.ci.librenms.org

@murrant murrant changed the title from Use foreach $key => value to refactor: discovery code cleanups Jun 16, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Jun 16, 2017

Auto-Deploy finished, Test PR at http://6856.ci.librenms.org or https://6856.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jun 19, 2017

Member

If you want this PR merged sooner, please rebase to include the fix for Travis breaking on PHP 5.6 tests

Member

laf commented Jun 19, 2017

If you want this PR merged sooner, please rebase to include the fix for Travis breaking on PHP 5.6 tests

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Jun 19, 2017

Auto-Deploy finished, Test PR at http://6856.ci.librenms.org or https://6856.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 19, 2017

The inspection completed: 2 updated code elements

scrutinizer-notifier commented Jun 19, 2017

The inspection completed: 2 updated code elements

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jun 19, 2017

Member

No rush, just reading through this code for something else. Trying to make it easier to understand. Should be no behavior changes.

Member

murrant commented Jun 19, 2017

No rush, just reading through this code for something else. Trying to make it easier to understand. Should be no behavior changes.

@laf laf merged commit 90aa485 into librenms:master Jun 22, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:foreach-key-value branch Jun 22, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.