New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Basic Support for Benu OS #6857

Merged
merged 16 commits into from Jun 22, 2017

Conversation

Projects
None yet
4 participants
@dnapper
Contributor

dnapper commented Jun 16, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 16, 2017

Auto-Deploy finished, Test PR at http://6857.ci.librenms.org or https://6857.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 16, 2017

Auto-Deploy finished, Test PR at http://6857.ci.librenms.org or https://6857.ci.librenms.org

@dnapper dnapper closed this Jun 16, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jun 17, 2017

Member

How come you've closed this one?

Member

laf commented Jun 17, 2017

How come you've closed this one?

@dnapper

This comment has been minimized.

Show comment
Hide comment
@dnapper

dnapper Jun 18, 2017

Contributor
Contributor

dnapper commented Jun 18, 2017

@laf laf reopened this Jun 18, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jun 18, 2017

Member

That's an issue with travis not you :)

Member

laf commented Jun 18, 2017

That's an issue with travis not you :)

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 18, 2017

Auto-Deploy finished, Test PR at http://6857.ci.librenms.org or https://6857.ci.librenms.org

@dnapper

This comment has been minimized.

Show comment
Hide comment
@dnapper

dnapper Jun 18, 2017

Contributor
Contributor

dnapper commented Jun 18, 2017

@laf

Great start on this PR. Some changes I feel are needed to get this merged in.

Also, can you drop the .txt extension from the MIB file names please.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jun 19, 2017

Member

If you want this PR merged sooner, please rebase to include the fix for Travis breaking on PHP 5.6 tests

Member

laf commented Jun 19, 2017

If you want this PR merged sooner, please rebase to include the fix for Travis breaking on PHP 5.6 tests

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6857.ci.librenms.org or https://6857.ci.librenms.org

@laf

Just a few small changes and this is good to merge.

Show outdated Hide outdated includes/discovery/mempools/benuos.inc.php
Show outdated Hide outdated includes/definitions/benu.yaml
Show outdated Hide outdated includes/polling/processors/benuos.inc.php
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6857.ci.librenms.org or https://6857.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6857.ci.librenms.org or https://6857.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6857.ci.librenms.org or https://6857.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6857.ci.librenms.org or https://6857.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6857.ci.librenms.org or https://6857.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jun 20, 2017

Auto-Deploy finished, Test PR at http://6857.ci.librenms.org or https://6857.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jun 21, 2017

Member

Sorry one last thing, why haven't you used sysObjectId for detection rather than sysDescr?

Looks like .1.3.6.1.4.1.39406.1. is unique enough to detect these.

Member

laf commented Jun 21, 2017

Sorry one last thing, why haven't you used sysObjectId for detection rather than sysDescr?

Looks like .1.3.6.1.4.1.39406.1. is unique enough to detect these.

@dnapper

This comment has been minimized.

Show comment
Hide comment
@dnapper

dnapper Jun 21, 2017

Contributor

forgot to make that change.
i'll push it shortly.

Contributor

dnapper commented Jun 21, 2017

forgot to make that change.
i'll push it shortly.

dnapper and others added some commits Jun 21, 2017

@laf

laf approved these changes Jun 22, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 22, 2017

The inspection completed: 2 updated code elements

scrutinizer-notifier commented Jun 22, 2017

The inspection completed: 2 updated code elements

@laf laf merged commit 02a7949 into librenms:master Jun 22, 2017

2 of 3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@dnapper dnapper deleted the dnapper:add-benu branch Feb 2, 2018

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.