New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Reorganised alerting docs + added some clarifications #6869

Merged
merged 2 commits into from Jun 25, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Jun 20, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jun 20, 2017

Member

Breaking the docs into smaller pages is a good thing, but it we need better navigation. Like a link list on the left side.

Member

murrant commented Jun 20, 2017

Breaking the docs into smaller pages is a good thing, but it we need better navigation. Like a link list on the left side.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jun 21, 2017

Member

I don't think it's possible to have a custom TOC per page. we might be able to fudge it with headings in each doc.

Member

laf commented Jun 21, 2017

I don't think it's possible to have a custom TOC per page. we might be able to fudge it with headings in each doc.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jun 21, 2017

Member

I'll give it a look.

Member

murrant commented Jun 21, 2017

I'll give it a look.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 23, 2017

The inspection completed: 1 updated code elements

The inspection completed: 1 updated code elements

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jun 24, 2017

Member

My main problem with breaking things up into smaller pages is it is difficult to move between the the pages. Like there is not go to next page.

Member

murrant commented Jun 24, 2017

My main problem with breaking things up into smaller pages is it is difficult to move between the the pages. Like there is not go to next page.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jun 24, 2017

Member

That is a problem but is it a worse problem to have than a huge wall of text?

Member

laf commented Jun 24, 2017

That is a problem but is it a worse problem to have than a huge wall of text?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jun 25, 2017

Member

Wish we had a little more control...

Member

murrant commented Jun 25, 2017

Wish we had a little more control...

@murrant murrant merged commit 84814ef into librenms:master Jun 25, 2017

2 of 3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:docs/alerting-tidyup branch Jun 25, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.