New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: finish logic and definition separation #6883

Merged
merged 1 commit into from Jul 3, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Jun 24, 2017

Clean up rewrites to only have function definitions
Move authentication initialization into a function

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

refactor: try prevent function exists errors if init is called twice
Clean up rewrites to only have function definitions
Move authentication initialization into a function
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 24, 2017

The inspection completed: 6 new issues, 11 updated code elements

The inspection completed: 6 new issues, 11 updated code elements

@murrant murrant changed the title from refactor: try prevent function exists errors if init is called twice to refactor: finish logic and definition separation Jun 28, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 1, 2017

Member

I have no way to test anything other than mysql and http-auth - both of which are minimal changes and work fine :)

Member

laf commented Jul 1, 2017

I have no way to test anything other than mysql and http-auth - both of which are minimal changes and work fine :)

@laf

laf approved these changes Jul 1, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 3, 2017

Member

I tested it with AD auth

Member

murrant commented Jul 3, 2017

I tested it with AD auth

@murrant murrant merged commit 20b08cf into librenms:master Jul 3, 2017

2 of 3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:snmp-scan-threaded branch Jul 3, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.