New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support fdb table on generic devices #6902

Merged
merged 5 commits into from Jun 29, 2017

Conversation

Projects
None yet
6 participants
@murrant
Member

murrant commented Jun 28, 2017

That implement Q-BRIDGE-MIB or BRIDGE-MIB

refactored code to use snmpwalk_group()
modified snmpwalk_group() so it works as intended
refactored ajax table code to use joins and reduce extra queries
add indexes for device_id and port_id, drop primary index
Make all columns sortable
Fix a few other small issues

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

murrant added some commits Jun 28, 2017

feature: support fdb table on generic devices
refactored code to use snmpwalk_group
refactored ajax table code to use joins and reduce extra queries
add indexes for device_id and port_id, drop primary index
Make all columns sortable
Fix a few other small issues
@kkrumm1

This comment has been minimized.

Show comment
Hide comment
@kkrumm1

kkrumm1 Jun 28, 2017

Member

Fancy! Works with my HP Procurves and some 3coms heh 👍

Member

kkrumm1 commented Jun 28, 2017

Fancy! Works with my HP Procurves and some 3coms heh 👍

@lundgrenolof

This comment has been minimized.

Show comment
Hide comment
@lundgrenolof

lundgrenolof Jun 29, 2017

I tested this and it found FDB tables on my HP Procurve devices. It did not find anything on zyxel gs2200, openwrt, generic linux, esxi or ubiquiti router.

For how long are records saved?

lundgrenolof commented Jun 29, 2017

I tested this and it found FDB tables on my HP Procurve devices. It did not find anything on zyxel gs2200, openwrt, generic linux, esxi or ubiquiti router.

For how long are records saved?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jun 29, 2017

Member

@lundgrenolof the records are updated each discovery. So they will stay that long.

Devices need to return fdb data via snmp to be supported. There is a standard MIB for that Q-BRIDGE-MIB and BRIDGE-MIB. If you have a device you know returns data, open a new issue and it will likely get added.

Member

murrant commented Jun 29, 2017

@lundgrenolof the records are updated each discovery. So they will stay that long.

Devices need to return fdb data via snmp to be supported. There is a standard MIB for that Q-BRIDGE-MIB and BRIDGE-MIB. If you have a device you know returns data, open a new issue and it will likely get added.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 29, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf laf merged commit e8dd72e into librenms:master Jun 29, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fdb-generic branch Jun 29, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.