New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed netman voltage and load divisor values #6905

Merged
merged 2 commits into from Jun 29, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Jun 28, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Voltage has technically been there since the fork but was checking voltages until that was fixed a few months ago and in turn enabling the code and breaking the divisor - I'm assuming it's broken for more than just the reporter.

load needed to be a divisor of 1 rather than default to 10.

Fixes: #6893 - Hope it doesn't break other installs

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 28, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@sorano sorano referenced this pull request Jun 29, 2017

Closed

Netman UPS snmp-module, displays incorrect values #6893

5 of 5 tasks complete

@murrant murrant merged commit a4b905e into librenms:master Jun 29, 2017

2 of 3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/issue-6893 branch Jun 29, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.