New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Improved install experience #6915

Merged
merged 1 commit into from Jul 1, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Jun 29, 2017

always check that the base sql has been imported.
async db building
After this merge, we could move install.php to the end of the install documentation. Makes a more natural flow.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

feature: improved install experience
always check that the base sql has been imported.
async db building
After this merge, we could move install.php to the end of the install documentation.  Makes a more natural flow.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jun 29, 2017

Thank you for submitting a PR @murrant! We have found the following @f0o, @laf and @paulgear based on the history of these files to review this PR.

mention-bot commented Jun 29, 2017

Thank you for submitting a PR @murrant! We have found the following @f0o, @laf and @paulgear based on the history of these files to review this PR.

@murrant murrant added the WebUI label Jun 29, 2017

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jun 29, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jun 29, 2017

The inspection completed: No new issues

@murrant murrant changed the title from feature: improved install experience to feature: Improved install experience Jul 1, 2017

@laf

laf approved these changes Jul 1, 2017

@laf laf merged commit f02b551 into librenms:master Jul 1, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:improve-install branch Jul 2, 2017

murrant added a commit to murrant/librenms that referenced this pull request Jul 3, 2017

feature: Improved install experience (librenms#6915)
always check that the base sql has been imported.
async db building
After this merge, we could move install.php to the end of the install documentation.  Makes a more natural flow.
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.