New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fdb tables multiple IPs and IPs from other devices adding extra rows #6930

Merged
merged 1 commit into from Jul 4, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Jul 3, 2017

Fix missing IPs because the ARP entries are on different port_id
Update arp discovery to use snmpwalk_group() additional fix in that function
Fix removal of arp entries
Fix a debug output type in fdb discovery

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: fdb tables multiple IPs and IPs from other devices adding extra …
…rows

Fix missing IPs because the ARP entries are on different port_id
Update arp discovery to use snmpwalk_group() additional fix in that function
Fix removal of arp entries
Fix a debug output type in fdb discovery
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 3, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @Tristan-Labbe and @paulgear based on the history of these files to review this PR.

mention-bot commented Jul 3, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @Tristan-Labbe and @paulgear based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Jul 3, 2017

Auto-Deploy finished, Test PR at http://6930.ci.librenms.org or https://6930.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 3, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 3, 2017

The inspection completed: No new issues

@laf laf merged commit b56c6b6 into librenms:master Jul 4, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fdb-fixes-round-2 branch Jul 4, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.