Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use the new locks for schema updates #6931
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
No code changes inside the block (try ?w=1 on the github url)
@laf I don't think that is what the discovery lock was for. I remember someone having long running new device discovery.
On this PR, do you think we should make it wait before continuing or just continue straight away like it is now?
Also, will this work for distributed pollers?
@murrant The long running issue was multiple stacked new discoveries which https://github.com/murrant/librenms/blob/c8c6bd0f1f410b1a5c75d81f34071f24080f2da8/discovery.php#L36 fixes.
I don't think waiting is the best option really
@laf From the MySQL docs:
So, assuming that is not the case, things should work. I don't have access to either of those setups at this time.
So, sounds like a a no. Perhaps we need a fallback to file based locking?