New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: minor visual changes in schedule maintenance window and its modal #6934

Merged
merged 3 commits into from Jul 4, 2017

Conversation

Projects
None yet
5 participants
@aldemira
Contributor

aldemira commented Jul 3, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@aldemira

This comment has been minimized.

Show comment
Hide comment
@aldemira

aldemira Jul 3, 2017

Contributor

Here are the before-after screenshots of the changes:

screen shot 2017-07-03 at 13 04 06
screen shot 2017-07-03 at 13 04 31
screen shot 2017-07-03 at 13 04 40
screen shot 2017-07-03 at 13 04 49

Contributor

aldemira commented Jul 3, 2017

Here are the before-after screenshots of the changes:

screen shot 2017-07-03 at 13 04 06
screen shot 2017-07-03 at 13 04 31
screen shot 2017-07-03 at 13 04 40
screen shot 2017-07-03 at 13 04 49

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 3, 2017

Auto-Deploy finished, Test PR at http://6934.ci.librenms.org or https://6934.ci.librenms.org

@aldemira

This comment has been minimized.

Show comment
Hide comment
@aldemira

aldemira Jul 3, 2017

Contributor

Mind you, top modal window screenshot is the new one.

Contributor

aldemira commented Jul 3, 2017

Mind you, top modal window screenshot is the new one.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 3, 2017

Member

@aldemira guessed that by the ridiculous no/yes layout 😊

Member

murrant commented Jul 3, 2017

@aldemira guessed that by the ridiculous no/yes layout 😊

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 3, 2017

Auto-Deploy finished, Test PR at http://6934.ci.librenms.org or https://6934.ci.librenms.org

@aldemira aldemira changed the title from webui: minor visual changes in schedule maintenance window and it's modal to webui: minor visual changes in schedule maintenance window and its modal Jul 3, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 3, 2017

Member

Looks good, but while testing this, I noticed the alerts on this page never go away.

Create a window, omit mapped device, click save, alert appears, add it and save. Now create a new window, alert is still in the modal.

Also, the "Scheduling maintenance ok" alert never goes away after adding a window.

Member

murrant commented Jul 3, 2017

Looks good, but while testing this, I noticed the alerts on this page never go away.

Create a window, omit mapped device, click save, alert appears, add it and save. Now create a new window, alert is still in the modal.

Also, the "Scheduling maintenance ok" alert never goes away after adding a window.

@aldemira

This comment has been minimized.

Show comment
Hide comment
@aldemira

aldemira Jul 3, 2017

Contributor

OK, I see what you mean. I'll try to fix that.

Contributor

aldemira commented Jul 3, 2017

OK, I see what you mean. I'll try to fix that.

@aldemira

This comment has been minimized.

Show comment
Hide comment
@aldemira

aldemira Jul 4, 2017

Contributor

For the future schedules (status == 0) there are no nice labels, so I've named it "Set" with an info-warning, but we can rename it as incoming or something else.

Contributor

aldemira commented Jul 4, 2017

For the future schedules (status == 0) there are no nice labels, so I've named it "Set" with an info-warning, but we can rename it as incoming or something else.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 4, 2017

Auto-Deploy finished, Test PR at http://6934.ci.librenms.org or https://6934.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 4, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 4, 2017

The inspection completed: No new issues

@laf laf merged commit 9c957ee into librenms:master Jul 4, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 4, 2017

Member

Thanks as always @aldemira

Member

laf commented Jul 4, 2017

Thanks as always @aldemira

@aldemira aldemira deleted the aldemira:schedulemaint branch Jan 15, 2018

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.