Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: define standard ups-mib divisors properly #6942
Set default divisors for all devices and remove per-os overrides for them.
High possibility for breakage here if devices not listed here have non-standard behavior.
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
@laf Already discussed a bit on IRC. But the divisor for everything in UPS-MIB isn't just a flat 10 as suggested by the previous code.
Load and Voltage (except upsBatteryVoltage) have a divisor of 1.
This is why we keep having to define those for specific devices as bug reports come in.
This is upsBatteryVoltage:
@murrant That seems to suggest different divisors :(
@laf I'm not sure we use rfc1628 for any of those that report four digit battery voltages
As far as I can tell this should not change the behavior of any devices we know about and should limit the number of "workarounds" in this function to only devices that have non-standard behavior.