New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added support to cisco sensors to link them to ports + macro/docs for alerting #6959

Merged
merged 4 commits into from Aug 4, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Jul 4, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #1065

So what this does is it will link cisco entity sensors up to ports where applicable allowing you to alert on the sensor only if the port is up.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 4, 2017

Thank you for submitting a PR @laf! We have found the following @Rosiak, @murrant and @HenocKA based on the history of these files to review this PR.

mention-bot commented Jul 4, 2017

Thank you for submitting a PR @laf! We have found the following @Rosiak, @murrant and @HenocKA based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 4, 2017

Auto-Deploy finished, Test PR at http://6959.ci.librenms.org or https://6959.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 26, 2017

Member

Rebased.

Member

laf commented Jul 26, 2017

Rebased.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 1, 2017

Member

@librenms/reviewers anyone able to look at this?

Member

laf commented Aug 1, 2017

@librenms/reviewers anyone able to look at this?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 3, 2017

Member

Unless anyone want to block this, I'll merge later tonight @librenms/reviewers

Member

laf commented Aug 3, 2017

Unless anyone want to block this, I'll merge later tonight @librenms/reviewers

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 3, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 3, 2017

The inspection completed: No new issues

@laf laf merged commit 707b6c6 into librenms:master Aug 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:feature/issue-1065 branch Aug 4, 2017

@dsgagi

This comment has been minimized.

Show comment
Hide comment
@dsgagi

dsgagi Aug 28, 2017

Contributor

Hi laf,

It seems you have overwritten the PR changes made in functions.inc.php by mistake.

To be more precise, the changes were reverted in d814046#diff-67aaf7dd786395ce4cbd2c3996cf1bdc

I suppose you used an older version of functions.php.inc when you added support for Emerson energy systems.

Cheers,
Dragan

Contributor

dsgagi commented Aug 28, 2017

Hi laf,

It seems you have overwritten the PR changes made in functions.inc.php by mistake.

To be more precise, the changes were reverted in d814046#diff-67aaf7dd786395ce4cbd2c3996cf1bdc

I suppose you used an older version of functions.php.inc when you added support for Emerson energy systems.

Cheers,
Dragan

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.