New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change .htaccess to compensate for Apache bug #6971

Merged
merged 2 commits into from Jul 14, 2017

Conversation

Projects
None yet
7 participants
@lasseleegaard
Contributor

lasseleegaard commented Jul 6, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

lasseleegaard added some commits Jul 6, 2017

Merge pull request #1 from lasseleegaard/lasseleegaard-patch-1
fix: Change .htaccess to compensate for Apache bug
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Jul 6, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Jul 6, 2017

CLA assistant check
All committers have signed the CLA.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 6, 2017

Auto-Deploy finished, Test PR at http://6971.ci.librenms.org or https://6971.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 6, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 6, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 6, 2017

Member

This was reported as being broken in Apache 2.4.25. I've tested this change on a slightly earlier version and it's fine.

I don't know why it breaks in the first place as that's a valid rule but I did find a link that indicates it might be a bug in apache: https://serverfault.com/questions/847312/rewriting-urls-while-using-mod-proxy-fcgi-and-path-info-ends-up-with-error-404/847750#847750

This has been reported before so maybe it's about time we changed it.

Member

laf commented Jul 6, 2017

This was reported as being broken in Apache 2.4.25. I've tested this change on a slightly earlier version and it's fine.

I don't know why it breaks in the first place as that's a valid rule but I did find a link that indicates it might be a bug in apache: https://serverfault.com/questions/847312/rewriting-urls-while-using-mod-proxy-fcgi-and-path-info-ends-up-with-error-404/847750#847750

This has been reported before so maybe it's about time we changed it.

@laf

laf approved these changes Jul 6, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 13, 2017

Member

@librenms/reviewers anyone else?

Member

laf commented Jul 13, 2017

@librenms/reviewers anyone else?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 14, 2017

Member

Seems ok, but I don't have any apache to test on.

Member

murrant commented Jul 14, 2017

Seems ok, but I don't have any apache to test on.

@murrant murrant added the Bug 🐞 label Jul 14, 2017

@paulgear

This comment has been minimized.

Show comment
Hide comment
@paulgear

paulgear Jul 14, 2017

Member

I've applied this to my system running Apache 2.4.18-2ubuntu3.3 and it didn't seem to break anything, so I think we're safe to merge.

Member

paulgear commented Jul 14, 2017

I've applied this to my system running Apache 2.4.18-2ubuntu3.3 and it didn't seem to break anything, so I think we're safe to merge.

@laf laf merged commit 039e410 into librenms:master Jul 14, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.