New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate improvements #6973

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Jul 6, 2017

Always output header (may be missing mysql data)
Improve version display, now looks like '1.28-129-g74e6c3edf' --
Add mysqli to the list of required extensions, check extensions before init
Add dbIsConnected() function, used to check if we have db in version_info()
Do not die on IPv4 and IPv6 so validate can print errors.
Move git checks so they are output together
fix rrdtool 1.7.0 reports version as 1.7.01.7.0

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

validate improvements
Always output header (may be missing mysql data)
Improve version display, now looks like '1.28-129-g74e6c3edf' <tag>-<commits since tag>-<shortag>
Add mysqli to the list of required extensions, check extensions before init
Add dbIsConnected() function, used to check if we have db in version_info()
Do not die on IPv4 and IPv6 so validate can print errors.
Move git checks so they are output together
fix rrdtool 1.7.0 reports version as 1.7.01.7.0
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Jul 6, 2017

Auto-Deploy finished, Test PR at http://6973.ci.librenms.org or https://6973.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 6, 2017

The inspection completed: 1 new issues, 3 updated code elements

scrutinizer-notifier commented Jul 6, 2017

The inspection completed: 1 new issues, 3 updated code elements

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 6, 2017

Member

@murrant LibreNMS | 1.28-130-gae4e66999 - what does that even mean :)

Member

laf commented Jul 6, 2017

@murrant LibreNMS | 1.28-130-gae4e66999 - what does that even mean :)

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 7, 2017

Member

@laf I put it in the post but it got stripped. It means last tag-commits since tag-short commit hash

Member

murrant commented Jul 7, 2017

@laf I put it in the post but it got stripped. It means last tag-commits since tag-short commit hash

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 13, 2017

Member

So 1.28 = Tag

1.29 is the latest tag though:

-bash-4.2$ git describe --tags $(git rev-list --tags --max-count=1)
1.29
-bash-4.2$ ./validate.php
====================================
Component | Version
--------- | -------
LibreNMS  | 1.28-130-gae4e66999
Member

laf commented Jul 13, 2017

So 1.28 = Tag

1.29 is the latest tag though:

-bash-4.2$ git describe --tags $(git rev-list --tags --max-count=1)
1.29
-bash-4.2$ ./validate.php
====================================
Component | Version
--------- | -------
LibreNMS  | 1.28-130-gae4e66999
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 17, 2017

Member

I'll check it

Member

murrant commented Jul 17, 2017

I'll check it

@laf laf merged commit 1e77d4b into librenms:master Jul 17, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:validate-changes branch Jul 17, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.