New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added ability specify options for sensors yaml discovery #6985

Merged
merged 2 commits into from Jul 10, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Jul 8, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

This is from #6958 so that we don't have to wait for a week to merge it whilst we notify on the powerwalker changes.

@murrant Should be the same code / doc as you reviewed in #6958 but with the fix in the docs you mentioned.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 8, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @HenocKA and @tuxis-ie based on the history of these files to review this PR.

mention-bot commented Jul 8, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @HenocKA and @tuxis-ie based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 8, 2017

Auto-Deploy finished, Test PR at http://6985.ci.librenms.org or https://6985.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 8, 2017

Auto-Deploy finished, Test PR at http://6985.ci.librenms.org or https://6985.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 8, 2017

The inspection completed: 4 new issues, 1 updated code elements

scrutinizer-notifier commented Jul 8, 2017

The inspection completed: 4 new issues, 1 updated code elements

@murrant murrant merged commit d30e566 into librenms:master Jul 10, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:options-sensors branch Jul 10, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.