New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix all mib errors in base mib directory #7002

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
4 participants
@murrant
Member

murrant commented Jul 10, 2017

Move cabletron mibs into enterasys directory
move CISCO-LWAPP mibs into cisco directory and fix errors
remove MPLS-LDP mibs as I couldn't reconcile them and they seem unused
move watchguard IPSEC-ISAKMP-IKE-DOI-TC into watchguard directory
update several cisco mib files to remove errors
Fix typo in tripplite mib
Fix RADWIN-MIB-WINLINK1000 based on pdf I found online, some lines were missing, added the bare minimum to make it valid

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix all mib errors in base mib directory
Move cabletron mibs into enterasys directory
move CISCO-LWAPP mibs into cisco directory and fix errors
remove MPLS-LDP mibs as I couldn't reconcile them and they seem unused
move watchguard IPSEC-ISAKMP-IKE-DOI-TC into watchguard directory
update several cisco mib files to remove errors
Fix typo in tripplite mib
Fix RADWIN-MIB-WINLINK1000 based on pdf I found online, some lines were missing, added the bare minimum to make it valid
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 10, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 12, 2017

Member

Out of interest how did you work this out? Wondering if we can add some form of unit test.

Member

laf commented Jul 12, 2017

Out of interest how did you work this out? Wondering if we can add some form of unit test.

@laf laf merged commit 5bc2444 into librenms:master Jul 12, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 13, 2017

Member

Running snmptranslate with +ALL. We could probably make a test for it.

Only test each directory individually, otherwise it hits the max TCs.

Member

murrant commented Jul 13, 2017

Running snmptranslate with +ALL. We could probably make a test for it.

Only test each directory individually, otherwise it hits the max TCs.

@murrant murrant deleted the murrant:mib-cleanup branch Jul 14, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.