New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stop loading all oses when we have no db connection #7003

Merged
merged 3 commits into from Jul 21, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Jul 10, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Stop trying to load all oses if we have no db connection (install process).

Fixes: #7001

@laf laf added the Bug 🐞 label Jul 10, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 10, 2017

Thank you for submitting a PR @laf! We have found the following @murrant and @barryodonovan based on the history of these files to review this PR.

mention-bot commented Jul 10, 2017

Thank you for submitting a PR @laf! We have found the following @murrant and @barryodonovan based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 10, 2017

Auto-Deploy finished, Test PR at http://7003.ci.librenms.org or https://7003.ci.librenms.org

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 11, 2017

Member

@laf you sure this won't have any side effects?

We could force it to load all os (which doesn't require the db) if nodb is specified.

Member

murrant commented Jul 11, 2017

@laf you sure this won't have any side effects?

We could force it to load all os (which doesn't require the db) if nodb is specified.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 13, 2017

Member

Not 100% no but we call it with $existing = true so the DB is attempted to be used.

I can change it to pass false if nodb is set?

Member

laf commented Jul 13, 2017

Not 100% no but we call it with $existing = true so the DB is attempted to be used.

I can change it to pass false if nodb is set?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 14, 2017

Member

@laf Yeah, that is what I was thinking, take a performance penalty, but might cause less unexpected edge cases...

Member

murrant commented Jul 14, 2017

@laf Yeah, that is what I was thinking, take a performance penalty, but might cause less unexpected edge cases...

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 18, 2017

Member

@murrant Updated, tested and it now shows the module not being installed in install.php if mysqli isn't available.

Member

laf commented Jul 18, 2017

@murrant Updated, tested and it now shows the module not being installed in install.php if mysqli isn't available.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 18, 2017

Auto-Deploy finished, Test PR at http://7003.ci.librenms.org or https://7003.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 18, 2017

Auto-Deploy finished, Test PR at http://7003.ci.librenms.org or https://7003.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 18, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 18, 2017

The inspection completed: No new issues

@murrant murrant merged commit 08d3a26 into librenms:master Jul 21, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/issue-7001 branch Jul 21, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.