New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix for Rittal LCP graphs divisors #7014

Merged
merged 3 commits into from Jul 13, 2017

Conversation

Projects
None yet
5 participants
@FTBZ
Contributor

FTBZ commented Jul 12, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


  • Disabled unnecessary discovery modules
  • Corrected wrong divisors

Can't find a way to disable the wrong over graphs or to change them by the ones included in the definitions file.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 12, 2017

Auto-Deploy finished, Test PR at http://7014.ci.librenms.org or https://7014.ci.librenms.org

Show outdated Hide outdated includes/definitions/rittal-lcp.yaml
@@ -109,6 +109,21 @@
} $descr = preg_replace('/[T|t]emperature[|s]/', '', $descr);
}
if ($device['os'] == 'rittal-lcp') {

This comment has been minimized.

@laf

laf Jul 13, 2017

Member

Is this 100% applicable to all Rittal-lcp devices or based on the firmware?

@laf

laf Jul 13, 2017

Member

Is this 100% applicable to all Rittal-lcp devices or based on the firmware?

This comment has been minimized.

@FTBZ

FTBZ Jul 13, 2017

Contributor

Probably, because the LCP is only one product of the line at this time.

@FTBZ

FTBZ Jul 13, 2017

Contributor

Probably, because the LCP is only one product of the line at this time.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 13, 2017

Auto-Deploy finished, Test PR at http://7014.ci.librenms.org or https://7014.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 13, 2017

Auto-Deploy finished, Test PR at http://7014.ci.librenms.org or https://7014.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 13, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 13, 2017

The inspection completed: No new issues

@laf

laf approved these changes Jul 13, 2017

@laf laf merged commit 138fd29 into librenms:master Jul 13, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@FTBZ FTBZ deleted the FTBZ:rittal-lcp-v2 branch Jul 13, 2017

@FTBZ

This comment has been minimized.

Show comment
Hide comment
@FTBZ

FTBZ Jul 13, 2017

Contributor

@laf An idea how to change the default over graph that can't be edited for devices using the Entity MIB?

Contributor

FTBZ commented Jul 13, 2017

@laf An idea how to change the default over graph that can't be edited for devices using the Entity MIB?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 13, 2017

Member

You can change the over graph to any graphs as far as I know, just use the type= part of the graph url

Member

laf commented Jul 13, 2017

You can change the over graph to any graphs as far as I know, just use the type= part of the graph url

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 13, 2017

Member

@FTBZ might have ran into the OS defs cache. I might rip that out :)

Member

murrant commented Jul 13, 2017

@FTBZ might have ran into the OS defs cache. I might rip that out :)

@FTBZ

This comment has been minimized.

Show comment
Hide comment
@FTBZ

FTBZ Jul 14, 2017

Contributor

@murrant You're right, this morning it's working and I changed nothing. Thanks guys.

Contributor

FTBZ commented Jul 14, 2017

@murrant You're right, this morning it's working and I changed nothing. Thanks guys.

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.