New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: delhost: Added an empty option for device selection, and a minor db performance fix #7018

Merged
merged 3 commits into from Jul 14, 2017

Conversation

Projects
None yet
5 participants
@aldemira
Contributor

aldemira commented Jul 13, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 13, 2017

Thank you for submitting a PR @aldemira! We have found the following @arjitc, @laf and @murrant based on the history of these files to review this PR.

Thank you for submitting a PR @aldemira! We have found the following @arjitc, @laf and @murrant based on the history of these files to review this PR.

@aldemira aldemira changed the title from Delhost to webui: delhost: Added an empty option for device selection, and a minor db performance fix Jul 13, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated html/pages/delhost.inc.php
@@ -57,8 +57,9 @@
<label for="id" class="col-sm-2 control-label">Device:</label>
<div class="col-sm-10">
<select name="id" class="form-control" id="id">
<option>Please select</option>

This comment has been minimized.

@laf

laf Jul 13, 2017

Member

Worth adding disabled="disabled" here?

@laf

laf Jul 13, 2017

Member

Worth adding disabled="disabled" here?

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 14, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf laf merged commit 550e412 into librenms:master Jul 14, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@aldemira aldemira deleted the aldemira:delhost branch Jul 20, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.