New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return more descriptive error when adding duplicate devices on sysName #7019

Merged
merged 3 commits into from Jul 16, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Jul 13, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

-bash-4.2$ ./addhost.php localhost.localdomain
Already have host localhost.localdomain (web01.1.novalocal) due to duplicate sysName
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 13, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @zarya and @Rosiak based on the history of these files to review this PR.

mention-bot commented Jul 13, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @zarya and @Rosiak based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 13, 2017

Auto-Deploy finished, Test PR at http://7019.ci.librenms.org or https://7019.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 14, 2017

Auto-Deploy finished, Test PR at http://7019.ci.librenms.org or https://7019.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 16, 2017

Member

@murrant Thanks for tidying this up a bit more, I retested and only had one small change to make so merging this in.

Member

laf commented Jul 16, 2017

@murrant Thanks for tidying this up a bit more, I retested and only had one small change to make so merging this in.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 16, 2017

Auto-Deploy finished, Test PR at http://7019.ci.librenms.org or https://7019.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 16, 2017

The inspection completed: 2 updated code elements

scrutinizer-notifier commented Jul 16, 2017

The inspection completed: 2 updated code elements

@laf laf merged commit 20ce209 into librenms:master Jul 16, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:addhost-duplicate-sysname branch Jul 16, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 17, 2017

Member

Thanks @laf

Member

murrant commented Jul 17, 2017

Thanks @laf

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.