New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Send collected data to OpenTSDB #7022

Merged
merged 11 commits into from Jul 15, 2017

Conversation

Projects
None yet
6 participants
@yac01
Contributor

yac01 commented Jul 13, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 13, 2017

Thank you for submitting a PR @yac01! We have found the following @laf, @murrant and @BarbarossaTM based on the history of these files to review this PR.

mention-bot commented Jul 13, 2017

Thank you for submitting a PR @yac01! We have found the following @laf, @murrant and @BarbarossaTM based on the history of these files to review this PR.

Show outdated Hide outdated build.sql
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 13, 2017

Member

Tagging #6962 for future reference.

Member

laf commented Jul 13, 2017

Tagging #6962 for future reference.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 13, 2017

Auto-Deploy finished, Test PR at http://7022.ci.librenms.org or https://7022.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 13, 2017

Auto-Deploy finished, Test PR at http://7022.ci.librenms.org or https://7022.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 13, 2017

Auto-Deploy finished, Test PR at http://7022.ci.librenms.org or https://7022.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 13, 2017

Auto-Deploy finished, Test PR at http://7022.ci.librenms.org or https://7022.ci.librenms.org

@yac01

delete field co

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 13, 2017

Auto-Deploy finished, Test PR at http://7022.ci.librenms.org or https://7022.ci.librenms.org

@yac01 yac01 changed the title from Send collected data to OpenTSDB to feature:Send collected data to OpenTSDB Jul 13, 2017

@yac01 yac01 changed the title from feature:Send collected data to OpenTSDB to feature: Send collected data to OpenTSDB Jul 13, 2017

@yac01 yac01 closed this Jul 13, 2017

@yac01 yac01 reopened this Jul 13, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 13, 2017

Auto-Deploy finished, Test PR at http://7022.ci.librenms.org or https://7022.ci.librenms.org

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 14, 2017

Member

@yac01 Perhaps you should split the customer identification off into a separate pull request? I think there are more changes needed there, but the opentsdb support is close to ready.

Member

murrant commented Jul 14, 2017

@yac01 Perhaps you should split the customer identification off into a separate pull request? I think there are more changes needed there, but the opentsdb support is close to ready.

@yac01

This comment has been minimized.

Show comment
Hide comment
@yac01

yac01 Jul 14, 2017

Contributor

@murrant
You are right that is why you could merge my request with the master and I will think about how to add the customer identité field in the shema sql and I will make another request tomorrow to add it,
Just one last question about the configuration of opentsdb, should I put it as default in default.inc.php and put all a false or leave it like that and the one who want to use it will have that add this configuration in config.php As explained in the doc ?? thank you

Contributor

yac01 commented Jul 14, 2017

@murrant
You are right that is why you could merge my request with the master and I will think about how to add the customer identité field in the shema sql and I will make another request tomorrow to add it,
Just one last question about the configuration of opentsdb, should I put it as default in default.inc.php and put all a false or leave it like that and the one who want to use it will have that add this configuration in config.php As explained in the doc ?? thank you

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 14, 2017

Auto-Deploy finished, Test PR at http://7022.ci.librenms.org or https://7022.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 14, 2017

Member

I'm ok with this as well now, I'll edit the 'co' stuff out of docs for now though.

Member

laf commented Jul 14, 2017

I'm ok with this as well now, I'll edit the 'co' stuff out of docs for now though.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 14, 2017

Member

You can leave the defaults out, people will add this to config.php

Member

laf commented Jul 14, 2017

You can leave the defaults out, people will add this to config.php

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 14, 2017

Auto-Deploy finished, Test PR at http://7022.ci.librenms.org or https://7022.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 14, 2017

Auto-Deploy finished, Test PR at http://7022.ci.librenms.org or https://7022.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 14, 2017

The inspection completed: 1 updated code elements

scrutinizer-notifier commented Jul 14, 2017

The inspection completed: 1 updated code elements

@yac01

for me it's ok you can merge if it's ok for you also

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 15, 2017

Member

Yes default to false so users have to set it in config.php

Member

murrant commented Jul 15, 2017

Yes default to false so users have to set it in config.php

@laf

laf approved these changes Jul 15, 2017

@laf laf merged commit 294ec4d into librenms:master Jul 15, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.