New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added detection for Gestetner printers #7038

Merged
merged 3 commits into from Jul 17, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Jul 15, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #6948

Disabled mempool as it's picked up but is always 100%.

@laf laf added the Device 🖥 label Jul 15, 2017

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Jul 15, 2017

Auto-Deploy finished, Test PR at http://7038.ci.librenms.org or https://7038.ci.librenms.org

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 15, 2017

Member

Missing your snmprec

Member

murrant commented Jul 15, 2017

Missing your snmprec

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Jul 15, 2017

Auto-Deploy finished, Test PR at http://7038.ci.librenms.org or https://7038.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 16, 2017

Member

Should be all good now.

Member

laf commented Jul 16, 2017

Should be all good now.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Jul 16, 2017

Auto-Deploy finished, Test PR at http://7038.ci.librenms.org or https://7038.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 16, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 16, 2017

The inspection completed: No new issues

@murrant murrant merged commit 534595d into librenms:master Jul 17, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:newdevice/issue-6948 branch Jul 17, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.