New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added more support for APC sensors #7039

Merged
merged 3 commits into from Jul 22, 2017

Conversation

Projects
None yet
6 participants
@laf
Member

laf commented Jul 15, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #6955

@laf laf added the Device 🖥 label Jul 15, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 15, 2017

Thank you for submitting a PR @laf! We have found the following @murrant based on the history of these files to review this PR.

mention-bot commented Jul 15, 2017

Thank you for submitting a PR @laf! We have found the following @murrant based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 15, 2017

Auto-Deploy finished, Test PR at http://7039.ci.librenms.org or https://7039.ci.librenms.org

@Rosiak

This comment has been minimized.

Show comment
Hide comment
@Rosiak

Rosiak Jul 15, 2017

Contributor

Hey @laf,

Awesome work!
I've reviewed it and made the following adjustments:
https://p.libren.ms/view/8eaee8b1

I've removed the current and voltage as these are duplicates of what is found in includes/discovery/sensors/voltage,current/apc.inc.php

This results in this:
screen shot 2017-07-15 at 15 37 35

Contributor

Rosiak commented Jul 15, 2017

Hey @laf,

Awesome work!
I've reviewed it and made the following adjustments:
https://p.libren.ms/view/8eaee8b1

I've removed the current and voltage as these are duplicates of what is found in includes/discovery/sensors/voltage,current/apc.inc.php

This results in this:
screen shot 2017-07-15 at 15 37 35

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 15, 2017

Member

Thanks @Rosiak. You can push those changes directly to my branch if you get chance.

Member

laf commented Jul 15, 2017

Thanks @Rosiak. You can push those changes directly to my branch if you get chance.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 16, 2017

Member

@Rosiak How come you've removed rPDU2PhaseStatusTable from the OID. This table will be cached the first time it's called.

Member

laf commented Jul 16, 2017

@Rosiak How come you've removed rPDU2PhaseStatusTable from the OID. This table will be cached the first time it's called.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 18, 2017

Member

Rosiak, why not remove the sensors from includes/discovery/sensors/voltage,current/apc.inc.php ?

Member

murrant commented Jul 18, 2017

Rosiak, why not remove the sensors from includes/discovery/sensors/voltage,current/apc.inc.php ?

@Rosiak

This comment has been minimized.

Show comment
Hide comment
@Rosiak

Rosiak Jul 21, 2017

Contributor

I've committed my changes, however I haven't removed the duplicates as I'm not sure if we should do so? Will probably break graphs and alerts for existing users.

Nevertheless, this is what it looks like right now:
screen shot 2017-07-21 at 17 28 46

Contributor

Rosiak commented Jul 21, 2017

I've committed my changes, however I haven't removed the duplicates as I'm not sure if we should do so? Will probably break graphs and alerts for existing users.

Nevertheless, this is what it looks like right now:
screen shot 2017-07-21 at 17 28 46

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 21, 2017

Member

@Rosiak If you rename the index so it is the same, things should carry over.

Member

murrant commented Jul 21, 2017

@Rosiak If you rename the index so it is the same, things should carry over.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 21, 2017

Member

I've removed the duplicates in the YAML file. Mainly because the current apc code uses single digit indexes which I'd prefer to avoid in the yaml files.

Member

laf commented Jul 21, 2017

I've removed the duplicates in the YAML file. Mainly because the current apc code uses single digit indexes which I'd prefer to avoid in the yaml files.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 21, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 21, 2017

The inspection completed: No new issues

@murrant

Seems reasonable to me.

@Rosiak Rosiak merged commit 80b5a8c into librenms:master Jul 22, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:newdevice/issue-6955 branch Jul 22, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.