New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: added jira transport #7040

Merged
merged 5 commits into from Jul 19, 2017

Conversation

Projects
None yet
6 participants
@aldemira
Contributor

aldemira commented Jul 16, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

I think this needs to be tested with other Jira instances as well.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 16, 2017

Thank you for submitting a PR @aldemira! We have found the following @laf, @benwa and @miken32 based on the history of these files to review this PR.

Thank you for submitting a PR @aldemira! We have found the following @laf, @benwa and @miken32 based on the history of these files to review this PR.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
Show outdated Hide outdated includes/alerts/transport.jira.php
* along with this program. If not, see <http://www.gnu.org/licenses/>. */
/**
* SMSEagle API Transport

This comment has been minimized.

@murrant

murrant Jul 19, 2017

Member

missed rename

@murrant

murrant Jul 19, 2017

Member

missed rename

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 19, 2017

Member

Looks reasonable, I have no way to test of course.

Member

murrant commented Jul 19, 2017

Looks reasonable, I have no way to test of course.

@aldemira

This comment has been minimized.

Show comment
Hide comment
@aldemira

aldemira Jul 19, 2017

Contributor

Sure, fortunately someone on the communities.librenms.org had the chance to test it.

Contributor

aldemira commented Jul 19, 2017

Sure, fortunately someone on the communities.librenms.org had the chance to test it.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 19, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@laf laf merged commit c592f90 into librenms:master Jul 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@aldemira aldemira deleted the aldemira:jiraalerting branch Jul 20, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.