New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device: support collecting fdb for IOS-XE devices #7044

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Jul 17, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Replaces #7016

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 17, 2017

The inspection completed: No new issues

The inspection completed: No new issues

@network-guy

This comment has been minimized.

Show comment
Hide comment
@network-guy

network-guy Jul 17, 2017

Contributor

You beat me to it. I was just getting ready to fix my PR with those exact changes. I have validated that this works correctly.

Contributor

network-guy commented Jul 17, 2017

You beat me to it. I was just getting ready to fix my PR with those exact changes. I have validated that this works correctly.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 17, 2017

Member

Thanks for confirmation @network-guy

Sorry, you hadn't responded to that comment that you were going to fix it :) If you want you can re-submit your PR.

Member

murrant commented Jul 17, 2017

Thanks for confirmation @network-guy

Sorry, you hadn't responded to that comment that you were going to fix it :) If you want you can re-submit your PR.

@laf laf merged commit 97828ec into librenms:master Jul 17, 2017

3 checks passed

Auto-Deploy Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@network-guy

This comment has been minimized.

Show comment
Hide comment
@network-guy

network-guy Jul 17, 2017

Contributor

No worries @murrant, got tied up on other things. Thanks for getting it taken care of.

Contributor

network-guy commented Jul 17, 2017

No worries @murrant, got tied up on other things. Thanks for getting it taken care of.

@murrant murrant deleted the murrant:fdb-iosxe branch Jul 17, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.