New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Added script to test alerts #7050

Merged
merged 3 commits into from Jul 23, 2017

Conversation

Projects
None yet
4 participants
@laf
Member

laf commented Jul 18, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Added a cli script to force send an alert. The alert must be currently active but this gives you a forced cli approach to being able to debug.

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 18, 2017

Auto-Deploy finished, Test PR at http://7050.ci.librenms.org or https://7050.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment
@LibreNMS-CI

LibreNMS-CI commented Jul 18, 2017

Auto-Deploy finished, Test PR at http://7050.ci.librenms.org or https://7050.ci.librenms.org

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 21, 2017

Member

Trying to test this in my dev box, which may not have alerting properly set up.

When running the script ./scripts/test-alert.php -r 1 -h 1 I get no output.

No output if I run ./scripts/test-alert.php -r 99999 -h 99999 either.

Member

murrant commented Jul 21, 2017

Trying to test this in my dev box, which may not have alerting properly set up.

When running the script ./scripts/test-alert.php -r 1 -h 1 I get no output.

No output if I run ./scripts/test-alert.php -r 99999 -h 99999 either.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 21, 2017

Member

It needs to be an active alert that is triggering right now.

Member

laf commented Jul 21, 2017

It needs to be an active alert that is triggering right now.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 22, 2017

Member

Oh, I probably should have read the docs first :)

I made a quick change, seem reasonable?

Member

murrant commented Jul 22, 2017

Oh, I probably should have read the docs first :)

I made a quick change, seem reasonable?

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 22, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 22, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 22, 2017

Member

Perfectly :)

Member

laf commented Jul 22, 2017

Perfectly :)

@laf laf merged commit 66008a0 into librenms:master Jul 23, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:feature/test-alerts branch Jul 23, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.