New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newdevice: Siemens Ruggedcom Switches #7052

Merged
merged 5 commits into from Jul 18, 2017

Conversation

Projects
None yet
4 participants
@EnzoZafra
Contributor

EnzoZafra commented Jul 18, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Jul 18, 2017

Auto-Deploy finished, Test PR at http://7052.ci.librenms.org or https://7052.ci.librenms.org

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 18, 2017

Member

As always, thanks for submitting the PR :)

Looks like this should be called ros (https://support.industry.siemens.com/cs/document/109737193/ruggedcom-ros-v4-3-user-guide-for-i800-i801-i802-i803?dti=0&pnid=15306&lc=en-BR)

If you agree, can you update the names / filenames please or let me know and i'll sort it out.

Member

laf commented Jul 18, 2017

As always, thanks for submitting the PR :)

Looks like this should be called ros (https://support.industry.siemens.com/cs/document/109737193/ruggedcom-ros-v4-3-user-guide-for-i800-i801-i802-i803?dti=0&pnid=15306&lc=en-BR)

If you agree, can you update the names / filenames please or let me know and i'll sort it out.

@laf laf added the Device 🖥 label Jul 18, 2017

@EnzoZafra

This comment has been minimized.

Show comment
Hide comment
@EnzoZafra

EnzoZafra Jul 18, 2017

Contributor

No problem! Ill get it done. Should it be siemens-ros, ruggedcom-ros or just ros?

Contributor

EnzoZafra commented Jul 18, 2017

No problem! Ill get it done. Should it be siemens-ros, ruggedcom-ros or just ros?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 18, 2017

Member

imho just ros. If another ros turns up they can be vendor-ros :)

Member

laf commented Jul 18, 2017

imho just ros. If another ros turns up they can be vendor-ros :)

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Jul 18, 2017

Auto-Deploy finished, Test PR at http://7052.ci.librenms.org or https://7052.ci.librenms.org

@LibreNMS-CI

This comment has been minimized.

Show comment
Hide comment

LibreNMS-CI commented Jul 18, 2017

Auto-Deploy finished, Test PR at http://7052.ci.librenms.org or https://7052.ci.librenms.org

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 18, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 18, 2017

The inspection completed: No new issues

@laf laf merged commit bfaab85 into librenms:master Jul 18, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

laf added some commits Jul 18, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.