New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed Raspberry Pi sensors support #7068

Merged
merged 2 commits into from Aug 3, 2017

Conversation

Projects
None yet
5 participants
@laf
Member

laf commented Jul 21, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7057

Before we did an snmp query to check if it was a rPi. We still only do one query in each of these and if it's not valid we break out or carry on.

@laf laf added the Bug 🐞 label Jul 21, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 21, 2017

Thank you for submitting a PR @laf! We have found the following @crcro, @jquagga and @murrant based on the history of these files to review this PR.

mention-bot commented Jul 21, 2017

Thank you for submitting a PR @laf! We have found the following @crcro, @jquagga and @murrant based on the history of these files to review this PR.

@Jo0Lz

This comment has been minimized.

Show comment
Hide comment
@Jo0Lz

Jo0Lz Jul 24, 2017

So, I tried this patch...

OSMC:
image

Raspbian:
image

I see codec sensors added, on the OSMC one it added every codec twice. No voltages etc. yet.
The double temperature got added when trying to resolve the issue manually by trying things out this topic

Jo0Lz commented Jul 24, 2017

So, I tried this patch...

OSMC:
image

Raspbian:
image

I see codec sensors added, on the OSMC one it added every codec twice. No voltages etc. yet.
The double temperature got added when trying to resolve the issue manually by trying things out this topic

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 26, 2017

Member

@murrant Updated now. One thing with this though, I doubt the state worked before either as the output from the snmp query is a string which is never converted as we don't use a MIB here.

So the raspberrypi.sh script needs updating to output numerical info.

Member

laf commented Jul 26, 2017

@murrant Updated now. One thing with this though, I doubt the state worked before either as the output from the snmp query is a string which is never converted as we don't use a MIB here.

So the raspberrypi.sh script needs updating to output numerical info.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 26, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 26, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 27, 2017

Member

librenms/librenms-agent#140

Could be done better but I have little time or care for the application support right now :)

Member

laf commented Jul 27, 2017

librenms/librenms-agent#140

Could be done better but I have little time or care for the application support right now :)

@laf laf modified the milestone: 1.30 Jul 28, 2017

@murrant

murrant approved these changes Aug 3, 2017

@laf laf merged commit 779ed8b into librenms:master Aug 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:fix/issue-7057 branch Aug 3, 2017

kkrumm1 referenced this pull request Aug 27, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.