Add support for LDAP directories using member ... #707

Merged
merged 1 commit into from Apr 2, 2015

Projects

None yet

2 participants

@Ultra2D
Contributor
Ultra2D commented Apr 1, 2015

... in stead of memberUid and DN in stead of username for group members.

Used the same variables as Observium, see http://www.observium.org/wiki/Authentication_modules#OpenLDAP
Have not looked at the Observium code.

Also, eDirectory returns "-1" (or UNDEFINED when using /usr/bin/ldapcompare) when checking for a non existing attribute. Therefore '===true' is necessary.

Works for me, but someone should test it with another LDAP directory obviously.

@laf
Member
laf commented Apr 1, 2015

Thanks for the PR @Ultra2D. Could submit a PR (or another commit here) following:

http://docs.librenms.org/General/Contributing/

Something like: #645

@Ultra2D
Contributor
Ultra2D commented Apr 1, 2015

Hmm, I currently have set my email as private on Github, and used that address for the commit. Is something like @users.noreply.github.com accepted?

@laf
Member
laf commented Apr 1, 2015

Hi @Ultra2D We just need someway to actually get in touch so a masked email address will still be fine :)

@Ultra2D
Contributor
Ultra2D commented Apr 1, 2015

Done (I think, new to this): #710

@laf laf merged commit 49babf7 into librenms:master Apr 2, 2015

1 check passed

Scrutinizer No new issues
Details
This was referenced Apr 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment