New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: TSC Barcode printer #7074

Merged
merged 4 commits into from Jul 25, 2017

Conversation

Projects
None yet
3 participants
@aldemira
Contributor

aldemira commented Jul 24, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Sorry I couldn't find any svg logos for it.

aldemira added some commits Jul 24, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 24, 2017

Member

Can you pad the icon to 32x32 please.

Member

laf commented Jul 24, 2017

Can you pad the icon to 32x32 please.

Show outdated Hide outdated includes/definitions/tsc.yaml
type: printer
discovery:
- sysObjectId:
- .1.3.6.1.4.1.51966.2.6

This comment has been minimized.

@laf

laf Jul 25, 2017

Member

Looks like we can drop this to 1.3.6.1.4.1.51966. I'll update the pr and merge.

@laf

laf Jul 25, 2017

Member

Looks like we can drop this to 1.3.6.1.4.1.51966. I'll update the pr and merge.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 25, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 25, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 25, 2017

Member

Awesome, thanks :)

Member

laf commented Jul 25, 2017

Awesome, thanks :)

@laf laf merged commit bb20ac9 into librenms:master Jul 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@aldemira aldemira deleted the aldemira:tsc branch Jan 15, 2018

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.