New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add device status reason to up messages. #7085

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Jul 27, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Jul 27, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Jul 27, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 27, 2017

Member

Isn't that what already happens?

Member

laf commented Jul 27, 2017

Isn't that what already happens?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 27, 2017

Member

No, $response['status_reason'] is empty when the check succeeds.

Member

murrant commented Jul 27, 2017

No, $response['status_reason'] is empty when the check succeeds.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 27, 2017

Member

If it's empty and you aren't setting it to something non-empty then why is it now going to contain something.

Member

laf commented Jul 27, 2017

If it's empty and you aren't setting it to something non-empty then why is it now going to contain something.

@laf laf merged commit c3627ec into librenms:master Aug 1, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Aug 2, 2017

Member

@laf I am using $device['status_reason'], which will be the previous status reason ;)

Member

murrant commented Aug 2, 2017

@laf I am using $device['status_reason'], which will be the previous status reason ;)

@murrant murrant deleted the murrant:device-status-event branch Aug 2, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.