New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Create librenms-irc.service #7087

Merged
merged 2 commits into from Aug 16, 2017

Conversation

Projects
None yet
5 participants
@allano337
Contributor

allano337 commented Jul 27, 2017

basic systemd start up script that goes in /etc/systemd/system/librenms-irc.service it is set to start at boot, but it can be stopped or started just like any other systemd script ie. systemctl start librenms-irc.service

I will update doc's on how to implement for systemd on pull request #7084

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Create librenms-irc.service
basic systemd start up script goes in /etc/systemd/system/librenms-irc.service it is set to start at boot, but it can be stopped or started just like any other systemd script ie. systemctl start librenms-irc.service

@murrant murrant changed the title from Create librenms-irc.service to feature: Create librenms-irc.service Jul 28, 2017

@murrant

Doh, I tested this and I forgot ExecStart= must be a path to an executable, no variables are allowed there.
I added two small changes, this looks good to merge now.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 14, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 14, 2017

The inspection completed: No new issues

@murrant murrant merged commit 5dfff22 into librenms:master Aug 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.