New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create alteonos.yaml #7088

Merged
merged 9 commits into from Aug 4, 2017

Conversation

Projects
None yet
5 participants
@sfini
Contributor

sfini commented Jul 28, 2017

Add Support for radware/Alteon application Switch

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Create radware.yaml
Add Support for radware/Alteon application Switch
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Jul 28, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Jul 28, 2017

CLA assistant check
All committers have signed the CLA.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Jul 28, 2017

Member

You'll need to add a snmprec file for each entry in your discovery array.

Member

murrant commented Jul 28, 2017

You'll need to add a snmprec file for each entry in your discovery array.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 29, 2017

Member

@sfini Please also remove the comments from the yaml file.

Member

laf commented Jul 29, 2017

@sfini Please also remove the comments from the yaml file.

Update radware.yaml
Remove comment
@sfini

This comment has been minimized.

Show comment
Hide comment
@sfini

sfini Jul 31, 2017

Contributor

@murrant
Is snmpwalk ok ?

Contributor

sfini commented Jul 31, 2017

@murrant
Is snmpwalk ok ?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Jul 31, 2017

Member

@sfini We don't need snmpwalk, you just need to create a test unit file as per: http://docs.librenms.org/Developing/os/Test-Units/

Member

laf commented Jul 31, 2017

@sfini We don't need snmpwalk, you just need to create a test unit file as per: http://docs.librenms.org/Developing/os/Test-Units/

@sfini

This comment has been minimized.

Show comment
Hide comment
@sfini

sfini Aug 1, 2017

Contributor

@murrant
Hi Tony .. Added radware.snmprec ... Is it ok ?

Contributor

sfini commented Aug 1, 2017

@murrant
Hi Tony .. Added radware.snmprec ... Is it ok ?

Update radware.yaml
remove comment
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 1, 2017

Member

You've not pushed the file into this branch but into a new one :)

In https://github.com/sfini/librenms - Click on the master branch in the top left:

image

Select patch-1 branch, now add the file to that and it should push it here.

Member

laf commented Aug 1, 2017

You've not pushed the file into this branch but into a new one :)

In https://github.com/sfini/librenms - Click on the master branch in the top left:

image

Select patch-1 branch, now add the file to that and it should push it here.

@sfini

This comment has been minimized.

Show comment
Hide comment
@sfini

sfini Aug 2, 2017

Contributor

@murrant

All Done ... Thank you..

Contributor

sfini commented Aug 2, 2017

@murrant

All Done ... Thank you..

Show outdated Hide outdated includes/definitions/radware.yaml
@sfini

This comment has been minimized.

Show comment
Hide comment
@sfini

sfini Aug 3, 2017

Contributor

@laf
Done...

Contributor

sfini commented Aug 3, 2017

@laf
Done...

@laf

laf approved these changes Aug 3, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 3, 2017

Member

One last question, is radware the right name for the os? That seems to be the vendor name which we don't usually use. I.e Cisco have Cisco IOS so the os name is ios. What's the case here?

Member

laf commented Aug 3, 2017

One last question, is radware the right name for the os? That seems to be the vendor name which we don't usually use. I.e Cisco have Cisco IOS so the os name is ios. What's the case here?

@sfini sfini changed the title from Create radware.yaml to Create alteonos.yaml Aug 4, 2017

sfini added some commits Aug 4, 2017

@sfini

This comment has been minimized.

Show comment
Hide comment
@sfini

sfini Aug 4, 2017

Contributor

@laf
Hi Neil .. You're right .. The correct OS for this type is AlteonOS ...
There are another branches of RADWARE co. , that have other OS (like APSoluteOS, etc.)
So, i think is better to have different type of yaml files as you have for cisco ....
I have renamed radware.yaml in alteonos.yaml, and made all the changes.
I also pushed the alteonos.rb to the oxidized's github.

Contributor

sfini commented Aug 4, 2017

@laf
Hi Neil .. You're right .. The correct OS for this type is AlteonOS ...
There are another branches of RADWARE co. , that have other OS (like APSoluteOS, etc.)
So, i think is better to have different type of yaml files as you have for cisco ....
I have renamed radware.yaml in alteonos.yaml, and made all the changes.
I also pushed the alteonos.rb to the oxidized's github.

@sfini

This comment has been minimized.

Show comment
Hide comment
@sfini

sfini Aug 4, 2017

Contributor

@laf
Do i have to upload mib too ?

Contributor

sfini commented Aug 4, 2017

@laf
Do i have to upload mib too ?

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 4, 2017

Member

If you aren't making use of the mib (you aren't so far) then no.

Member

laf commented Aug 4, 2017

If you aren't making use of the mib (you aren't so far) then no.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 4, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 4, 2017

The inspection completed: No new issues

@laf laf merged commit 4e56ee1 into librenms:master Aug 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.