FortiGate Minor Change #709

Merged
merged 3 commits into from Apr 2, 2015

Projects

None yet

2 participants

@Rosiak
Contributor
Rosiak commented Apr 1, 2015
  • Add serial and hardware recognition
  • Clean up code
@Rosiak Rosiak FortiGate Minor Change
- Add serial and hardware recognition
- Clean up code
b689f79
@laf
Member
laf commented Apr 1, 2015

Quick question @Rosiak. you've got rid of the using rewrite_fortinet_hardware() which used sysObjectID to generate the hardware before to now using entPhysicalModelName. Does this work across all models or do we need to keep support for the old method as well?

@Rosiak Rosiak Update fortigate.inc.php
- Re-add the some of the old code to ensure backwards compatibility
a60eb07
@Rosiak
Contributor
Rosiak commented Apr 1, 2015

Adjusted according to the input from Lafwood.

@laf
Member
laf commented Apr 1, 2015

Nearly @Rosiak. You need to check for $hardware first so:

if (empty($hardware)) {
$hardware = snmp_get($device, "ENTITY-MIB::entPhysicalModelName.1", "-Ovq");
}

@Rosiak Rosiak Update fortigate.inc.php
-Another correction.
eff1c34
@laf laf merged commit 7f4c988 into librenms:master Apr 2, 2015

1 check passed

Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment