New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check session directory is writable before install.php #7103

Merged
merged 1 commit into from Aug 8, 2017

Conversation

Projects
None yet
5 participants
@murrant
Member

murrant commented Aug 2, 2017

Drop pear check.
A few html/bootstrap cleanups too.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: check session directory is writable before install.php
Drop pear check.
A few html/bootstrap cleanups too.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 2, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @f0o and @geordish based on the history of these files to review this PR.

mention-bot commented Aug 2, 2017

Thank you for submitting a PR @murrant! We have found the following @laf, @f0o and @geordish based on the history of these files to review this PR.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 2, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 2, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 2, 2017

Member

How come the pear check is dropped? Using it is part of the install guide which users should have already completed but also may not have.

Member

laf commented Aug 2, 2017

How come the pear check is dropped? Using it is part of the install guide which users should have already completed but also may not have.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Aug 2, 2017

Member

Well, I might have another PR... #7106

Member

murrant commented Aug 2, 2017

Well, I might have another PR... #7106

@laf laf merged commit 1098529 into librenms:master Aug 8, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@sTywin

This comment has been minimized.

Show comment
Hide comment
@sTywin

sTywin Sep 17, 2017

Contributor

On my default installation, this fails since session_save_path() returns an empty string, and thus is_writable("") returns 0. In this default condition, PHP will use /tmp as the session save path, which is indeed writable.

Contributor

sTywin commented Sep 17, 2017

On my default installation, this fails since session_save_path() returns an empty string, and thus is_writable("") returns 0. In this default condition, PHP will use /tmp as the session save path, which is indeed writable.

@murrant murrant deleted the murrant:validate-session branch Sep 18, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.