New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first and last value where always U since \" wasn't stripped from input #7111

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
5 participants
@funkestefan
Contributor

funkestefan commented Aug 3, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926


This change is Reviewable

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 3, 2017

Thank you for submitting a PR @funkestefan! We have found the following @laf, @murrant and @tuxis-ie based on the history of these files to review this PR.

mention-bot commented Aug 3, 2017

Thank you for submitting a PR @funkestefan! We have found the following @laf, @murrant and @tuxis-ie based on the history of these files to review this PR.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 3, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 3, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 4, 2017

Member

@murrant. I think we should apply the trim() from the previous PR to snmp_get(). We end up just adding trim('"', $value) all over the show right now. What do you reckon?

Member

laf commented Aug 4, 2017

@murrant. I think we should apply the trim() from the previous PR to snmp_get(). We end up just adding trim('"', $value) all over the show right now. What do you reckon?

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Aug 8, 2017

Member

@laf, probably. Again, I'm not that confident about the \

Member

murrant commented Aug 8, 2017

@laf, probably. Again, I'm not that confident about the \

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 8, 2017

Member

@murrant then we just switch to trim('"')

Member

laf commented Aug 8, 2017

@murrant then we just switch to trim('"')

@murrant murrant merged commit c39f3c7 into librenms:master Sep 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Sep 5, 2017

Member

@laf merging this for now, we can address the other change you suggested separately if you like.

Member

murrant commented Sep 5, 2017

@laf merging this for now, we can address the other change you suggested separately if you like.

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.