New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed avaya-ers.yaml to show ifName in WebUI #7113

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
4 participants
@tslytsly
Contributor

tslytsly commented Aug 3, 2017

ERS ifDescr is far to long and makes lists of ports unwieldy.
Changing it to ifName gives the same info, but in a shorter form.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

changed yaml to show ifName in WebUI
ERS ifDescr is far to long and makes lists of ports unwieldy.
Changing it to ifName gives the same info, but in a shorter form.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 3, 2017

Thank you for submitting a PR @tslytsly! We have found the following @laf based on the history of these files to review this PR.

mention-bot commented Aug 3, 2017

Thank you for submitting a PR @tslytsly! We have found the following @laf based on the history of these files to review this PR.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 3, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 3, 2017

The inspection completed: No new issues

@tslytsly tslytsly changed the title from changed yaml to show ifName in WebUI to changed avaya-ers.yaml to show ifName in WebUI Aug 3, 2017

@laf laf merged commit be4a4cd into librenms:master Aug 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

kkrumm1 referenced this pull request Aug 27, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.