New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace escapeshellcmd with Purifier in service checks #7118

Merged
merged 2 commits into from Aug 12, 2017

Conversation

Projects
None yet
4 participants
@E-t-z
Contributor

E-t-z commented Aug 4, 2017

Required for service checks, which include multiple quotes in arguments or regex.

Proposed patch tested, works.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

fix: issue #4934
Required for service checks, which include multiple quotes or regex.

Proposed patch tested, works.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 4, 2017

Thank you for submitting a PR @E-t-z! We have found the following @adaniels21487, @murrant and @laf based on the history of these files to review this PR.

mention-bot commented Aug 4, 2017

Thank you for submitting a PR @E-t-z! We have found the following @adaniels21487, @murrant and @laf based on the history of these files to review this PR.

fix: issue #4934
Required for service checks, which include multiple quotes or regex.

Proposed patch tested, works.
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 4, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 4, 2017

The inspection completed: No new issues

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 4, 2017

Member

This is a patch of mine from a while ago, probably better someone else reviews :)

Member

laf commented Aug 4, 2017

This is a patch of mine from a while ago, probably better someone else reviews :)

@laf laf changed the title from fix: issue #4934 to Replace escapeshellcmd with Purifier in service checks Aug 4, 2017

@E-t-z

This comment has been minimized.

Show comment
Hide comment
@E-t-z

E-t-z Aug 5, 2017

Contributor

@laf yep.

Hence the wording "proposed" and referral to issue and your patch.
Only difference, it is now tested and seems to be working fine, without causing any issues.

Contributor

E-t-z commented Aug 5, 2017

@laf yep.

Hence the wording "proposed" and referral to issue and your patch.
Only difference, it is now tested and seems to be working fine, without causing any issues.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 5, 2017

Member

Sorry my comment was to other maintainers :)

Member

laf commented Aug 5, 2017

Sorry my comment was to other maintainers :)

@E-t-z

This comment has been minimized.

Show comment
Hide comment
@E-t-z

E-t-z Aug 5, 2017

Contributor

Np, I just did not want anybody think, like I would submit someone elses hard work as mine :)

Contributor

E-t-z commented Aug 5, 2017

Np, I just did not want anybody think, like I would submit someone elses hard work as mine :)

@laf laf merged commit 0ebf436 into librenms:master Aug 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@E-t-z E-t-z deleted the E-t-z:patch-1 branch Aug 12, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.