Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Attempt to fix repeated sql issue we come across #7123
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
This is a repeat offender. We have to attempt to drop the primary key first for those who already have it as you can't attempt to add it back in if it exists, generates an error which means it will be flagged in travis, web ui and console installs as such.
It seems to work ok. At the end of the day it's only the queries people are running manually with the addition of dropping the primary key to stop errors being flagged.
As for the root cause. Difficult to say but we've now made so many changes to older schema files to try and fix the install process that I expect we catch people between two states now, one being that they've already run an older pre-modified schema change and then the second trying to run a later schema change which also fixed what we modified in older schemas but they weren't compatible.
Repeat occurrences of posts to the schema thread on community should be wrapped up and fixed. It's just noise we don't need.
I don't think anyone has a true idea of why we see the differences however....
I prefer # 1 and hope we don't see # 2