New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add AKCP dry contact state support #7124

Merged
merged 2 commits into from Aug 11, 2017

Conversation

Projects
None yet
4 participants
@Rosiak
Contributor

Rosiak commented Aug 4, 2017

fix #7100

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 4, 2017

Member

This looks like it can be done in yaml

Member

laf commented Aug 4, 2017

This looks like it can be done in yaml

@Rosiak

This comment has been minimized.

Show comment
Hide comment
@Rosiak

Rosiak Aug 5, 2017

Contributor

Sure, but can I exclude sensors like this:

+        if ($temp[$index]['hhmsSensorArraySwitchStatus'] != 'noStatus') {
Contributor

Rosiak commented Aug 5, 2017

Sure, but can I exclude sensors like this:

+        if ($temp[$index]['hhmsSensorArraySwitchStatus'] != 'noStatus') {
@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 6, 2017

Member

Sure, but can I exclude sensors like this:

  •    if ($temp[$index]['hhmsSensorArraySwitchStatus'] != 'noStatus') {
    

Yup, we actually get the numerical value in the yaml code as you need it. So you can do:

skip_values: 1

Member

laf commented Aug 6, 2017

Sure, but can I exclude sensors like this:

  •    if ($temp[$index]['hhmsSensorArraySwitchStatus'] != 'noStatus') {
    

Yup, we actually get the numerical value in the yaml code as you need it. So you can do:

skip_values: 1

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 11, 2017

Member

Switched to yaml:

image

Member

laf commented Aug 11, 2017

Switched to yaml:

image

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 11, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 11, 2017

The inspection completed: No new issues

@laf laf merged commit a84392c into librenms:master Aug 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@kristoferus75

This comment has been minimized.

Show comment
Hide comment
@kristoferus75

kristoferus75 Aug 12, 2017

Hi !

Thanks !!!

I dont know if its ok but i see the states now but in double version like this :

USV Carrier 230V ausgefallen		normal
USV Carrier 230V ausgefallen		2#
USV Carrier Stoerung		normal
USV Carrier Stoerung		2#
48V Gleichrichter 230V ausgefallen		normal
48V Gleichrichter 230V ausgefallen		2#
48V Gleichrichter Stoerung		normal
48V Gleichrichter Stoerung		2#
USV Koax Stoerung		normal
USV Koax Stoerung		2#

kind regrads

kristoferus75

kristoferus75 commented Aug 12, 2017

Hi !

Thanks !!!

I dont know if its ok but i see the states now but in double version like this :

USV Carrier 230V ausgefallen		normal
USV Carrier 230V ausgefallen		2#
USV Carrier Stoerung		normal
USV Carrier Stoerung		2#
48V Gleichrichter 230V ausgefallen		normal
48V Gleichrichter 230V ausgefallen		2#
48V Gleichrichter Stoerung		normal
48V Gleichrichter Stoerung		2#
USV Koax Stoerung		normal
USV Koax Stoerung		2#

kind regrads

kristoferus75

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 12, 2017

Member

I've just deleted all the states for mine and re-run disco:

image

Try run a rediscovery. Also if you ran the patch for this initially then you'll need to revert that as I moved it to yaml which would explain the duplicates.

Member

laf commented Aug 12, 2017

I've just deleted all the states for mine and re-run disco:

image

Try run a rediscovery. Also if you ran the patch for this initially then you'll need to revert that as I moved it to yaml which would explain the duplicates.

@kristoferus75

This comment has been minimized.

Show comment
Hide comment
@kristoferus75

kristoferus75 Aug 12, 2017

Hi Laf !

hmm rediscovery don't help but after delete and add the device again it looks now good !

but one thing a have noticed that the discovery takes a very long time at the point

disco module sensors !

polling time is ok !

kind regrads

kristoferus75

kristoferus75 commented Aug 12, 2017

Hi Laf !

hmm rediscovery don't help but after delete and add the device again it looks now good !

but one thing a have noticed that the discovery takes a very long time at the point

disco module sensors !

polling time is ok !

kind regrads

kristoferus75

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 12, 2017

Member

Discovery times shouldn't be an issue like it is with polling. But you can disable unneeded discovery modules as normal.

Member

laf commented Aug 12, 2017

Discovery times shouldn't be an issue like it is with polling. But you can disable unneeded discovery modules as normal.

@kristoferus75

This comment has been minimized.

Show comment
Hide comment
@kristoferus75

kristoferus75 Aug 12, 2017

ok thanks Laf !

kristoferus75 commented Aug 12, 2017

ok thanks Laf !

@kristoferus75

This comment has been minimized.

Show comment
Hide comment
@kristoferus75

kristoferus75 Aug 12, 2017

Sorry again !

I have seen that we also have sensorProbe2 in use !

after adding:
vi includes/definitions/akcp.yaml

  • sensorProbe2

the sensorprobe2 work !

Please update this in the git master !

thanks

kind regards

kristoferus75

kristoferus75 commented Aug 12, 2017

Sorry again !

I have seen that we also have sensorProbe2 in use !

after adding:
vi includes/definitions/akcp.yaml

  • sensorProbe2

the sensorprobe2 work !

Please update this in the git master !

thanks

kind regards

kristoferus75

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 12, 2017

Member

Please submit this yourself, it's an easy fix.

Member

laf commented Aug 12, 2017

Please submit this yourself, it's an easy fix.

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.