New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snmp exec support #7126

Merged
merged 3 commits into from Aug 11, 2017

Conversation

Projects
None yet
5 participants
@robje
Contributor

robje commented Aug 6, 2017

This pull request adds snmp exec support for dmidecode hardware detection

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 6, 2017

Thank you for submitting a PR @robje! We have found the following @murrant, @ciscoqid and @InsaneSplash based on the history of these files to review this PR.

mention-bot commented Aug 6, 2017

Thank you for submitting a PR @robje! We have found the following @murrant, @ciscoqid and @InsaneSplash based on the history of these files to review this PR.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Aug 6, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Aug 6, 2017

CLA assistant check
All committers have signed the CLA.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 8, 2017

Member

Thanks for the PR. @robje You need to sign the CLA still, it might be because you need to ensure the user your commit is done as is your github user and the email is in your account.

Member

laf commented Aug 8, 2017

Thanks for the PR. @robje You need to sign the CLA still, it might be because you need to ensure the user your commit is done as is your github user and the email is in your account.

@robje

This comment has been minimized.

Show comment
Hide comment
@robje

robje Aug 9, 2017

Contributor

@laf, I did not know this about the commit email. Added it to my profile later, but can't get it to be reprocessed.

Contributor

robje commented Aug 9, 2017

@laf, I did not know this about the commit email. Added it to my profile later, but can't get it to be reprocessed.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 9, 2017

Member

:( When you click the https://cla-assistant.io/librenms/librenms?pullRequest=7126 link, the email address it shows there, was that the one that this was committed with?

Member

laf commented Aug 9, 2017

:( When you click the https://cla-assistant.io/librenms/librenms?pullRequest=7126 link, the email address it shows there, was that the one that this was committed with?

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 9, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 9, 2017

The inspection completed: No new issues

@robje

This comment has been minimized.

Show comment
Hide comment
@robje

robje Aug 9, 2017

Contributor

I don't see an email address on the cla-assistant page.

The initial email I received mentioned:

Rob J. Epping seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

I did add the email address but still no go.

Contributor

robje commented Aug 9, 2017

I don't see an email address on the cla-assistant page.

The initial email I received mentioned:

Rob J. Epping seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

I did add the email address but still no go.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 10, 2017

Member

What does this show for you:

-bash-4.2$ git config -l|grep -P '^user\.'
user.name=laf
user.email=gh+n@laf.io

The name and email are my github details so the CLA maps that back from the commits to GH and I can sign the CLA. If they don't match it can't work out if you've signed it.

Member

laf commented Aug 10, 2017

What does this show for you:

-bash-4.2$ git config -l|grep -P '^user\.'
user.name=laf
user.email=gh+n@laf.io

The name and email are my github details so the CLA maps that back from the commits to GH and I can sign the CLA. If they don't match it can't work out if you've signed it.

@robje

This comment has been minimized.

Show comment
Hide comment
@robje

robje Aug 10, 2017

Contributor

this:

epping@librenms-dev:/opt/librenms$ git config -l | grep ^user
user.name=Rob J. Epping
user.email=epping@renf.us
user.name=Rob J. Epping
user.email=librenms@renf.us
epping@librenms-dev:/opt/librenms$ 

first set is global, second set is from librenms.

Must user.name match the github name?

Contributor

robje commented Aug 10, 2017

this:

epping@librenms-dev:/opt/librenms$ git config -l | grep ^user
user.name=Rob J. Epping
user.email=epping@renf.us
user.name=Rob J. Epping
user.email=librenms@renf.us
epping@librenms-dev:/opt/librenms$ 

first set is global, second set is from librenms.

Must user.name match the github name?

@laf laf merged commit cdf8021 into librenms:master Aug 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@robje robje deleted the robje:snmp-exec-support branch May 8, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 7, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.