New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fan and temp sensor state discovery Avaya ERS 3500 #7117 #7134

Merged
merged 3 commits into from Aug 10, 2017

Conversation

Projects
None yet
4 participants
@tslytsly
Contributor

tslytsly commented Aug 9, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Aug 9, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Aug 9, 2017

CLA assistant check
All committers have signed the CLA.

@tslytsly tslytsly changed the title from Added fan and temp sensor state discovery Avaya ERS 3500 to Added fan and temp sensor state discovery Avaya ERS 3500 #7117 Aug 9, 2017

@tslytsly

This comment has been minimized.

Show comment
Hide comment
@tslytsly

tslytsly Aug 9, 2017

Contributor

Issue: #7117

Contributor

tslytsly commented Aug 9, 2017

Issue: #7117

@tslytsly

This comment has been minimized.

Show comment
Hide comment
@tslytsly

tslytsly Aug 9, 2017

Contributor

Not sure why it says I have not signed the CLA, cos I have.

Contributor

tslytsly commented Aug 9, 2017

Not sure why it says I have not signed the CLA, cos I have.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 9, 2017

Member

I've made a few tweaks: 747b8e1

Can you give it a test?

Member

laf commented Aug 9, 2017

I've made a few tweaks: 747b8e1

Can you give it a test?

@tslytsly

This comment has been minimized.

Show comment
Hide comment
@tslytsly

tslytsly Aug 10, 2017

Contributor

yep works fine.

Contributor

tslytsly commented Aug 10, 2017

yep works fine.

laf and others added some commits Aug 8, 2017

newdevice: Added support for Emerson energy systems (#7128)
* newdevice: Added support for Emerson energy systems

* added missing test

* Update ees.yaml

Added Avaya ERS fan and temp state discovery
removed some left over debug code
Update avaya-ers.inc.php
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 10, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 10, 2017

The inspection completed: No new issues

@laf laf merged commit 34a070f into librenms:master Aug 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@tslytsly tslytsly deleted the tslytsly:issue-7117 branch Aug 10, 2017

@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.