New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Allow host renames with selinux enforcing #7136

Merged
merged 3 commits into from Aug 11, 2017

Conversation

Projects
None yet
5 participants
@kedearian
Contributor

kedearian commented Aug 9, 2017

you have to change the fcontext of /opt/librenms/rrd/ to allow read/write.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Allow host renames with selinux enforcing
you have to change the fcontext of /opt/librenms/rrd/ to allow read/write.
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Aug 9, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Aug 9, 2017

CLA assistant check
All committers have signed the CLA.

@kedearian kedearian changed the title from Allow host renames with selinux enforcing to Docs: Allow host renames with selinux enforcing Aug 9, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Aug 9, 2017

Member

This is covered by #6920

Member

murrant commented Aug 9, 2017

This is covered by #6920

@kedearian

This comment has been minimized.

Show comment
Hide comment
@kedearian

kedearian Aug 9, 2017

Contributor

Sorry i was going off the docs from http://docs.librenms.org/Installation/Installation-CentOS-7-Nginx/#selinux and didn't see this. I'll close my pull.

Contributor

kedearian commented Aug 9, 2017

Sorry i was going off the docs from http://docs.librenms.org/Installation/Installation-CentOS-7-Nginx/#selinux and didn't see this. I'll close my pull.

@kedearian kedearian closed this Aug 9, 2017

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Aug 9, 2017

Member

No, it's good to make this change now. I was just making a note.

Member

murrant commented Aug 9, 2017

No, it's good to make this change now. I was just making a note.

@murrant murrant reopened this Aug 9, 2017

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 9, 2017

Member

So @murrant's PR has semanage fcontext -a -t httpd_sys_content_t '/opt/librenms/rrd(/.*)?' as well. If you both agree this should be in then I'll add it to this PR and merge.

Member

laf commented Aug 9, 2017

So @murrant's PR has semanage fcontext -a -t httpd_sys_content_t '/opt/librenms/rrd(/.*)?' as well. If you both agree this should be in then I'll add it to this PR and merge.

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Aug 10, 2017

Member

Sounds good @laf that way we get more correct installs while we wait for the other PR to merge.

Member

murrant commented Aug 10, 2017

Sounds good @laf that way we get more correct installs while we wait for the other PR to merge.

@kedearian

This comment has been minimized.

Show comment
Hide comment
@kedearian

kedearian Aug 11, 2017

Contributor

Sounds good to me as well, thanks.

Contributor

kedearian commented Aug 11, 2017

Sounds good to me as well, thanks.

kedearian and others added some commits Aug 11, 2017

Update Installation-CentOS-7-Nginx.md
Changed to add semanage fcontext -a -t httpd_sys_content_t '/opt/librenms/rrd(/.*)?' to complete the selinux change.
@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 11, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 11, 2017

The inspection completed: No new issues

@laf laf merged commit 38cb8ab into librenms:master Aug 11, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.