New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added further sensor support for Geist Watchdog #7143

Merged
merged 2 commits into from Aug 19, 2017

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Aug 11, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7082

Adds some more functions:

conv_fahrenheit() This converts fahrenheit to celsius. It re-uses another function to simplify things

return_number() This parses the value passed and returns just a numerical value.

Fixes issues with existing sensor discovery in some files.

Added new ones via yaml. The device provided to test against barely had any sensors available so this is all from the mib....

image

@laf laf added the Device 🖥 label Aug 11, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 11, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @paulgear and @BarbarossaTM based on the history of these files to review this PR.

mention-bot commented Aug 11, 2017

Thank you for submitting a PR @laf! We have found the following @murrant, @paulgear and @BarbarossaTM based on the history of these files to review this PR.

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 11, 2017

The inspection completed: 1 new issues, 2 updated code elements

scrutinizer-notifier commented Aug 11, 2017

The inspection completed: 1 new issues, 2 updated code elements

@laf laf merged commit 25d79ce into librenms:master Aug 19, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:device/issue-7082 branch Aug 19, 2017

neg2led added a commit to neg2led/librenms that referenced this pull request Aug 21, 2017

newdevice: Added further sensor support for Geist Watchdog (#7143)
* newdevice: Added further sensor support for Geist Watchdog

* relaxed if check

@GordSpence GordSpence referenced this pull request Aug 28, 2017

Closed

Geist Watchdog 15 temperature graphing incorrect data #7236

4 of 5 tasks complete
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.