New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Udated edgecos OS polling V2 #7153

Merged
merged 3 commits into from Aug 14, 2017

Conversation

Projects
None yet
4 participants
@erotel
Contributor

erotel commented Aug 14, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Add new devices:

ECS 4510
ECS 4210
ECS 3510
ES 3528 MV2

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Aug 14, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Aug 14, 2017

CLA assistant check
All committers have signed the CLA.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Aug 14, 2017

Member

Thanks @erotel. Just needs the blank lines removing as per: https://travis-ci.org/librenms/librenms/jobs/264336827

Member

laf commented Aug 14, 2017

Thanks @erotel. Just needs the blank lines removing as per: https://travis-ci.org/librenms/librenms/jobs/264336827

@erotel

This comment has been minimized.

Show comment
Hide comment
@erotel

erotel Aug 14, 2017

Contributor

I'm sorry I forgot the script php scripts/pre-commit.php -s
Fixed

Contributor

erotel commented Aug 14, 2017

I'm sorry I forgot the script php scripts/pre-commit.php -s
Fixed

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Aug 14, 2017

The inspection completed: No new issues

scrutinizer-notifier commented Aug 14, 2017

The inspection completed: No new issues

@laf laf merged commit dc41c9d into librenms:master Aug 14, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@lock

This comment has been minimized.

Show comment
Hide comment
@lock

lock bot May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.